* [patch] xfsqa 078 - use rmdir to remove directories
@ 2008-05-22 6:11 David Chinner
2008-05-22 13:22 ` Christoph Hellwig
2008-07-10 22:42 ` Dave Chinner
0 siblings, 2 replies; 3+ messages in thread
From: David Chinner @ 2008-05-22 6:11 UTC (permalink / raw)
To: xfs-dev; +Cc: xfs-oss
If test 078 fails and you try to run it again immediately, it
will execute a 'rm -f' on a directory which will fail. This should
be a rmdir....
Signed-off-by: Dave Chinner <dgc@sgi.com>
---
xfstests/078 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: xfs-cmds/xfstests/078
===================================================================
--- xfs-cmds.orig/xfstests/078 2008-03-20 09:10:02.000000000 +1100
+++ xfs-cmds/xfstests/078 2008-05-15 23:21:58.192413673 +1000
@@ -50,8 +50,8 @@ _filter_io()
# real QA test starts here
echo "*** create loop mount point"
-rm -f $LOOP_MNT 2>/dev/null
-mkdir $LOOP_MNT || _fail "cannot create loopback mount point"
+rmdir $LOOP_MNT 2>/dev/null
+mkdir -p $LOOP_MNT || _fail "cannot create loopback mount point"
_grow_loop()
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] xfsqa 078 - use rmdir to remove directories
2008-05-22 6:11 [patch] xfsqa 078 - use rmdir to remove directories David Chinner
@ 2008-05-22 13:22 ` Christoph Hellwig
2008-07-10 22:42 ` Dave Chinner
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2008-05-22 13:22 UTC (permalink / raw)
To: David Chinner; +Cc: xfs-dev, xfs-oss
On Thu, May 22, 2008 at 04:11:20PM +1000, David Chinner wrote:
>
> If test 078 fails and you try to run it again immediately, it
> will execute a 'rm -f' on a directory which will fail. This should
> be a rmdir....
Looks good. rm -rf woul also do it, although slightly more dangerous :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] xfsqa 078 - use rmdir to remove directories
2008-05-22 6:11 [patch] xfsqa 078 - use rmdir to remove directories David Chinner
2008-05-22 13:22 ` Christoph Hellwig
@ 2008-07-10 22:42 ` Dave Chinner
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2008-07-10 22:42 UTC (permalink / raw)
To: xfs
ping?
On Thu, May 22, 2008 at 04:11:20PM +1000, David Chinner wrote:
>
> If test 078 fails and you try to run it again immediately, it
> will execute a 'rm -f' on a directory which will fail. This should
> be a rmdir....
>
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
> xfstests/078 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: xfs-cmds/xfstests/078
> ===================================================================
> --- xfs-cmds.orig/xfstests/078 2008-03-20 09:10:02.000000000 +1100
> +++ xfs-cmds/xfstests/078 2008-05-15 23:21:58.192413673 +1000
> @@ -50,8 +50,8 @@ _filter_io()
> # real QA test starts here
>
> echo "*** create loop mount point"
> -rm -f $LOOP_MNT 2>/dev/null
> -mkdir $LOOP_MNT || _fail "cannot create loopback mount point"
> +rmdir $LOOP_MNT 2>/dev/null
> +mkdir -p $LOOP_MNT || _fail "cannot create loopback mount point"
>
> _grow_loop()
> {
>
>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-10 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-22 6:11 [patch] xfsqa 078 - use rmdir to remove directories David Chinner
2008-05-22 13:22 ` Christoph Hellwig
2008-07-10 22:42 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox