From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: remove i_gen from incore inode
Date: Mon, 21 Jul 2008 21:08:14 +1000 [thread overview]
Message-ID: <20080721110814.GC6761@disturbed> (raw)
In-Reply-To: <20080721075449.GB6692@infradead.org>
On Mon, Jul 21, 2008 at 03:54:49AM -0400, Christoph Hellwig wrote:
> On Sun, Jul 20, 2008 at 10:46:42PM +1000, Dave Chinner wrote:
> > i_gen is incremented in directory operations when the
> > directory is changed. It is never read or otherwise used
> > so it should be removed to help reduce the size of the
> > struct xfs_inode.
>
> It also removes a xfs_trans_log_inode in xfs_remove, which looks
> fine to me from a quick glance, but this should be verified and
> documented.
If you note in the very next if/else statement the directory inode
gets logged - either by dropping the link or directly. IOWs, we
were logging the directory inode twice with the same value
(XFS_ILOG_CORE). So I don't think thereśs any problem here.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-21 11:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 12:46 [PATCH] XFS: remove i_gen from incore inode Dave Chinner
2008-07-21 7:54 ` Christoph Hellwig
2008-07-21 11:08 ` Dave Chinner [this message]
2008-07-21 11:52 ` Christoph Hellwig
2008-07-21 12:04 ` Dave Chinner
2008-07-21 12:05 ` Christoph Hellwig
2008-08-11 16:39 ` Christoph Hellwig
2008-11-21 18:01 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2008-09-13 13:47 Dave Chinner
2008-09-14 13:16 ` Christoph Hellwig
2008-10-07 22:12 Dave Chinner
2008-10-22 6:20 ` Dave Chinner
2008-10-31 1:27 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721110814.GC6761@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox