Re: [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes

Mark Goodwin
2008-07-23T05:00:04Z

Eric Sandeen wrote:
> Mark Goodwin wrote:
>
>> As above, just run QA for cleanups.
>
> Out of curiosity, will you trust this? You'll run QA anyway, right?

yes we run it anyway, so maybe this (as a requirement) is overkill.

> And do you very often find errors in submitted patches by running QA?
>

don't know, but it is part of the review process. For cleanups,
bugs/regressions seem to be fairly rare (hence they're subtle and
unexpected). I think you found one such regression a while back,
(after a herculean effort).

Cheers
-- Mark