From: Dave Chinner <david@fromorbit.com>
To: Mark Goodwin <markgw@sgi.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Christoph Hellwig <hch@infradead.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes
Date: Wed, 23 Jul 2008 14:27:21 +1000 [thread overview]
Message-ID: <20080723042721.GI5947@disturbed> (raw)
In-Reply-To: <4886ADB6.5060109@sgi.com>
On Wed, Jul 23, 2008 at 02:04:06PM +1000, Mark Goodwin wrote:
>
> Eric Sandeen wrote:
>> Mark Goodwin wrote:
>> For general algorithm improvements... how do you write a new QA test for
>> "Use the inode tree for finding dirty inodes?"
>
> Case by case basis I guess. e.g. write a test that exercises or stresses
> the changed algorithm or functionality, especially corner cases
> (low space, full AGs, mem pressure, whatever).
Most of these corner cases are already covered by XFSQA.
> Performance regression testing
> is trickier - need access to suitable h/w and the historical data; so it's
> probably best run on dedicated h/w every night against the dev tree.
Performance regressions are something that generally are only
detected some time after the commit occurs - usually when it gets to
the wider community. Once again, it's an argument for further
distributing the QA load by committing quickly.
Indeed, in the case of regressions caused by commmunity
contributions, I think a bugzilla bug needs to be raised to
track it properly....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-23 4:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 12:19 [PATCH 0/4] XFS: replace the mount inode list with radix tree traversals Dave Chinner
2008-07-20 12:19 ` [PATCH 1/4] XFS: Remove xfs_iflush_all and clean up xfs_finish_reclaim_all() Dave Chinner
2008-07-21 7:58 ` Christoph Hellwig
2008-07-21 11:33 ` Dave Chinner
2008-07-22 4:24 ` Christoph Hellwig
2008-07-20 12:19 ` [PATCH 2/4] XFS: Use the inode tree for finding dirty inodes Dave Chinner
2008-07-22 4:28 ` Christoph Hellwig
2008-07-22 5:30 ` Dave Chinner
2008-07-22 7:27 ` Christoph Hellwig
2008-07-23 0:05 ` Dave Chinner
2008-07-23 2:10 ` Mark Goodwin
2008-07-23 3:46 ` Eric Sandeen
2008-07-23 4:04 ` Mark Goodwin
2008-07-23 4:09 ` Eric Sandeen
2008-07-23 5:00 ` Mark Goodwin
2008-07-23 4:27 ` Dave Chinner [this message]
2008-07-23 4:18 ` Dave Chinner
2008-07-23 15:37 ` Russell Cattelan
2008-07-24 6:02 ` Mark Goodwin
2008-07-25 3:55 ` Russell Cattelan
2008-07-25 4:08 ` Mark Goodwin
2008-07-25 5:40 ` Russell Cattelan
2008-07-25 6:55 ` Niv Sardi
2008-07-23 20:49 ` Christoph Hellwig
2008-07-24 11:46 ` Dave Chinner
2008-07-20 12:19 ` [PATCH 3/4] XFS: Traverse inode trees when releasing dquots Dave Chinner
2008-07-20 12:19 ` [PATCH 4/4] XFS: remove the mount inode list Dave Chinner
2008-07-22 4:29 ` Christoph Hellwig
2008-07-22 5:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723042721.GI5947@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=markgw@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox