From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/5] implement IHOLD/IRELE directly
Date: Thu, 24 Jul 2008 08:55:48 +1000 [thread overview]
Message-ID: <20080723225548.GO6761@disturbed> (raw)
In-Reply-To: <20080723194950.GF6188@lst.de>
On Wed, Jul 23, 2008 at 09:49:50PM +0200, Christoph Hellwig wrote:
> Now that all direct calls to VN_HOLD/VN_RELE are gone we can implement
> IHOLD/IRELE directly.
>
> For the IHOLD case also replace igrab with a direct increment of i_count
> because we are guaranteed to already have a live and referenced inode
> by the VFS. Also remove the vn_hold statistic because it's been rather
> meaningless for some time with most references done by other callers.
Seeing as you are changing from an igrab() to a straight
atomic_inc(), can you put an:
ASSERT(atomic_read(&VFS_I(ip)->i_count) > 0)
into the IHOLD macro so we catch screwups in reference counting as
quickly as possible?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-23 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 19:49 [PATCH 5/5] implement IHOLD/IRELE directly Christoph Hellwig
2008-07-23 22:55 ` Dave Chinner [this message]
2008-07-24 6:22 ` Christoph Hellwig
2008-07-24 8:07 ` Christoph Hellwig
2008-07-24 8:21 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723225548.GO6761@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox