* [PATCH 3/4] fix the noquota mount option
@ 2008-05-25 19:07 Christoph Hellwig
2008-07-23 8:05 ` Christoph Hellwig
2008-07-24 7:07 ` Dave Chinner
0 siblings, 2 replies; 4+ messages in thread
From: Christoph Hellwig @ 2008-05-25 19:07 UTC (permalink / raw)
To: xfs
Noquota should clear all mount options, and not just user and group
quota. Probably doesn't matter very much in real life.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:57:33.000000000 +0200
+++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:58:52.000000000 +0200
@@ -337,6 +337,7 @@ xfs_parseargs(
} else if (!strcmp(this_char, MNTOPT_NOQUOTA)) {
mp->m_qflags &= ~(XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
+ XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
XFS_UQUOTA_ENFD | XFS_OQUOTA_ENFD);
} else if (!strcmp(this_char, MNTOPT_QUOTA) ||
!strcmp(this_char, MNTOPT_UQUOTA) ||
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/4] fix the noquota mount option
2008-05-25 19:07 [PATCH 3/4] fix the noquota mount option Christoph Hellwig
@ 2008-07-23 8:05 ` Christoph Hellwig
2008-08-28 23:18 ` Christoph Hellwig
2008-07-24 7:07 ` Dave Chinner
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2008-07-23 8:05 UTC (permalink / raw)
To: xfs
ping?
On Sun, May 25, 2008 at 09:07:50PM +0200, Christoph Hellwig wrote:
> Noquota should clear all mount options, and not just user and group
> quota. Probably doesn't matter very much in real life.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:57:33.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:58:52.000000000 +0200
> @@ -337,6 +337,7 @@ xfs_parseargs(
> } else if (!strcmp(this_char, MNTOPT_NOQUOTA)) {
> mp->m_qflags &= ~(XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
> XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
> + XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
> XFS_UQUOTA_ENFD | XFS_OQUOTA_ENFD);
> } else if (!strcmp(this_char, MNTOPT_QUOTA) ||
> !strcmp(this_char, MNTOPT_UQUOTA) ||
---end quoted text---
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/4] fix the noquota mount option
2008-07-23 8:05 ` Christoph Hellwig
@ 2008-08-28 23:18 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2008-08-28 23:18 UTC (permalink / raw)
To: xfs
ping^2?
On Wed, Jul 23, 2008 at 10:05:14AM +0200, Christoph Hellwig wrote:
> ping?
>
> On Sun, May 25, 2008 at 09:07:50PM +0200, Christoph Hellwig wrote:
> > Noquota should clear all mount options, and not just user and group
> > quota. Probably doesn't matter very much in real life.
> >
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c
> > ===================================================================
> > --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:57:33.000000000 +0200
> > +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-05-25 20:58:52.000000000 +0200
> > @@ -337,6 +337,7 @@ xfs_parseargs(
> > } else if (!strcmp(this_char, MNTOPT_NOQUOTA)) {
> > mp->m_qflags &= ~(XFS_UQUOTA_ACCT | XFS_UQUOTA_ACTIVE |
> > XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
> > + XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE |
> > XFS_UQUOTA_ENFD | XFS_OQUOTA_ENFD);
> > } else if (!strcmp(this_char, MNTOPT_QUOTA) ||
> > !strcmp(this_char, MNTOPT_UQUOTA) ||
> ---end quoted text---
---end quoted text---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/4] fix the noquota mount option
2008-05-25 19:07 [PATCH 3/4] fix the noquota mount option Christoph Hellwig
2008-07-23 8:05 ` Christoph Hellwig
@ 2008-07-24 7:07 ` Dave Chinner
1 sibling, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2008-07-24 7:07 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Sun, May 25, 2008 at 09:07:50PM +0200, Christoph Hellwig wrote:
> Noquota should clear all mount options, and not just user and group
> quota. Probably doesn't matter very much in real life.
ACK. I noticed this discrepency reviewing the previous patch
and wondered about it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-28 23:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-25 19:07 [PATCH 3/4] fix the noquota mount option Christoph Hellwig
2008-07-23 8:05 ` Christoph Hellwig
2008-08-28 23:18 ` Christoph Hellwig
2008-07-24 7:07 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox