From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/15] split up xfs_btree_init_cursor
Date: Fri, 25 Jul 2008 09:25:37 +1000 [thread overview]
Message-ID: <20080724232537.GD15438@disturbed> (raw)
In-Reply-To: <20080723200835.GD7401@lst.de>
On Wed, Jul 23, 2008 at 10:08:35PM +0200, Christoph Hellwig wrote:
> xfs_btree_init_cursor contains close to little shared code for the different
> btrees and will get even more non-common code in the future. Split it up
> into one routine per btree type.
>
> Because xfs_btree_dup_cursor needs to call the init routine for a generic
> btree cursor add a new btree operation vector that contains a dup_cursor
> method that initializes a new cursor based on an existing one.
>
> The btree operations vector is based on an idea and code from Dave Chinner
> and will be used for more operations later on.
Looks ok to me.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-07-24 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 20:08 [PATCH 03/15] split up xfs_btree_init_cursor Christoph Hellwig
2008-07-24 23:25 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724232537.GD15438@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox