From: Christoph Hellwig <hch@lst.de>
To: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] update timestamp in xfs_ialloc manually
Date: Sat, 26 Jul 2008 11:14:59 +0200 [thread overview]
Message-ID: <20080726091459.GB29710@lst.de> (raw)
In-Reply-To: <20080726090725.GR5947@disturbed>
On Sat, Jul 26, 2008 at 07:07:25PM +1000, Dave Chinner wrote:
> On Sat, Jul 26, 2008 at 08:33:31AM +0200, Christoph Hellwig wrote:
> > In xfs_ialloc we just want to set all timestamps to the current time.
> > We don't need to mark the inode dirty like xfs_ichgtime does, and we
> > don't need nor want the opimizations in xfs_ichgtime that I will
> > introduce in the next patch.
>
> Looks sane, and solves an issue with code I'm working on, too.
>
> FWIW, the conditional check against I_NEW before marking the
> indo dirty can be removed as well, as this was call that required
> avoiding avoiding it.
Yeah. Will update and retest the patch.
prev parent reply other threads:[~2008-07-26 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 6:33 [PATCH 1/3] update timestamp in xfs_ialloc manually Christoph Hellwig
2008-07-26 9:07 ` Dave Chinner
2008-07-26 9:14 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080726091459.GB29710@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox