public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: [PATCH 00/21] btree cleanups and unification
Date: Tue, 29 Jul 2008 21:30:00 +0200	[thread overview]
Message-ID: <20080729193000.GA19104@lst.de> (raw)

This is the full btree unficiation based on Dave's initial patches plus
various cleanups.  This second versions post now contains the complete
btree refactoring, and passes XFSQA.

The two first patches from the first round have been merged, so they are
not included anymore.  In the reposted patches not much has changed,
only the readahead helpers have been renamed and the tracing infrastructure
has been improved a little.

The real news is the missing btree operations, including all the hairy
ones.  These have been reimplemented looking at the three original
btrees and Daves code, in doubt going with the former.  That means the
small helpers to insert/remove/move records are gone now in favour of
following the original code more closely.  This fixed the one off error
showing up in the intial refactoring.

There's a lot of new comments and empty lines, so by diffstat the new
code isn't all that much smaller:

	36 files changed, 6041 insertions(+), 7128 deletions(-)

but the (debug) binary modules is almost 15kb smaller:

	   text	   data	    bss	    dec	    hex	filename
	 631577	   4227	   3092	 638896	  9bfb0	fs/xfs/xfs.ko.old
	 616929	   4435	   3124	 624488	  98768	fs/xfs/xfs.ko.btree

I have not run any benchmarks yet to see what the performance impact is,
and I still have some ideas to optimize the code.
-- 

             reply	other threads:[~2008-07-29 19:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29 19:30 Christoph Hellwig [this message]
2008-07-30  0:53 ` [PATCH 00/21] btree cleanups and unification Dave Chinner
2008-08-01 19:34   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080729193000.GA19104@lst.de \
    --to=hch@lst.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox