From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 13/21] implement generic xfs_btree_update
Date: Sat, 2 Aug 2008 11:15:23 +1000 [thread overview]
Message-ID: <20080802011523.GM6201@disturbed> (raw)
In-Reply-To: <20080801194624.GG1263@lst.de>
On Fri, Aug 01, 2008 at 09:46:24PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2008 at 03:29:59PM +1000, Dave Chinner wrote:
> > Oh, it's be moved inside the update code itself. So, why always call
> > the update function and then check the ptr? Why not the way it was
> > originally done?
>
> Because all three callers do different checks, and I could not proof
> that they are either identical or hamrless for the other cases.
> We can clean this mess up later in small standalone patches.
Ok. Sounds like a good plan.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-08-02 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:31 [PATCH 13/21] implement generic xfs_btree_update Christoph Hellwig
2008-07-30 5:29 ` Dave Chinner
2008-08-01 19:46 ` Christoph Hellwig
2008-08-02 1:15 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080802011523.GM6201@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox