From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 15/21] implement generic xfs_btree_rshift
Date: Sat, 2 Aug 2008 11:20:42 +1000 [thread overview]
Message-ID: <20080802012042.GN6201@disturbed> (raw)
In-Reply-To: <20080801194914.GI1263@lst.de>
On Fri, Aug 01, 2008 at 09:49:14PM +0200, Christoph Hellwig wrote:
> > > + XFS_BB_NUM_BITS, &first, &last);
> > > + xfs_trans_log_buf(cur->bc_tp, bp, first, last);
> > > + } else {
> > > + /* XXX(hch): maybe factor out into a method? */
> > > + xfs_trans_log_inode(cur->bc_tp, cur->bc_private.b.ip,
> > > + XFS_ILOG_FBROOT(cur->bc_private.b.whichfork));
> >
> > I don't think it is necessary at this point.
>
> It's the only leakage of the detailed inode root implementation into
> the generic code, so I'm still wondering whether a method would be
> better.
Ah, right. yes, it probably would be cleaner to do it as a
separate method, but Ǐ don't think it's that important right now.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-08-02 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:31 [PATCH 15/21] implement generic xfs_btree_rshift Christoph Hellwig
2008-07-30 6:08 ` Dave Chinner
2008-08-01 19:49 ` Christoph Hellwig
2008-08-02 1:20 ` Dave Chinner [this message]
2008-08-02 15:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080802012042.GN6201@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox