[PATCH] Don't release root inode until finished using it

[PATCH] Don't release root inode until finished using it

[Lachlan McIlroy]

During unmount we're releasing the last reference on the root inode
before we've finished using it so move it after the XFS_SEND_UNMOUNT
hook.

--- a/fs/xfs/linux-2.6/xfs_super.c	2008-08-05 13:12:39.000000000 +1000
+++ b/fs/xfs/linux-2.6/xfs_super.c	2008-08-04 14:34:56.000000000 +1000
@@ -1132,8 +1132,6 @@ xfs_fs_put_super(
 	error = xfs_unmount_flush(mp, 0);
 	WARN_ON(error);
 
-	IRELE(rip);
-
 	/*
 	 * If we're forcing a shutdown, typically because of a media error,
 	 * we want to make sure we invalidate dirty pages that belong to
@@ -1149,6 +1147,8 @@ xfs_fs_put_super(
 				unmount_event_flags);
 	}
 
+	IRELE(rip);
+
 	xfs_unmountfs(mp);
 	xfs_icsb_destroy_counters(mp);
 	xfs_close_devices(mp);

Re: [PATCH] Don't release root inode until finished using it

[Dave Chinner]

On Tue, Aug 05, 2008 at 04:33:24PM +1000, Lachlan McIlroy wrote:
> During unmount we're releasing the last reference on the root inode
> before we've finished using it so move it after the XFS_SEND_UNMOUNT
> hook.

Looks ok.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH] Don't release root inode until finished using it

[Christoph Hellwig]

Looks good, but I've already sent a nicer version on the 26th:

[PATCH 1/6] move root inode IRELE into xfs_unmountfs


Sometimes I wish people would at least glance over my patches when they
hit the list..

Re: [PATCH] Don't release root inode until finished using it

[Lachlan McIlroy]

Christoph Hellwig wrote:
> Looks good, but I've already sent a nicer version on the 26th:
> 
> [PATCH 1/6] move root inode IRELE into xfs_unmountfs
> 
> 
> Sometimes I wish people would at least glance over my patches when they
> hit the list..

Some of us are trying to fix bugs and don't have time to look at every
cleanup patch that hits the list.