* PATCH] trivial xfs_remove comment fixup
@ 2008-08-07 21:58 Christoph Hellwig
2008-08-08 0:33 ` Dave Chinner
2008-10-18 12:36 ` [PATCH] " Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Christoph Hellwig @ 2008-08-07 21:58 UTC (permalink / raw)
To: xfs
The dp to ip comment should be for the unconditional xfs_droplink
call, and the "." link obviously only exists for directories,
so it should be in the is_dir conditional.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_vnodeops.c 2008-08-06 17:26:37.000000000 -0300
+++ linux-2.6-xfs/fs/xfs/xfs_vnodeops.c 2008-08-06 17:36:44.000000000 -0300
@@ -2014,7 +2014,7 @@ xfs_remove(
goto out_bmap_cancel;
/*
- * Drop the link from dp to ip.
+ * Drop the "." link from ip to self.
*/
error = xfs_droplink(tp, ip);
if (error)
@@ -2029,7 +2029,7 @@ xfs_remove(
}
/*
- * Drop the "." link from ip to self.
+ * Drop the link from dp to ip.
*/
error = xfs_droplink(tp, ip);
if (error)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH] trivial xfs_remove comment fixup
2008-08-07 21:58 PATCH] trivial xfs_remove comment fixup Christoph Hellwig
@ 2008-08-08 0:33 ` Dave Chinner
2008-10-18 12:36 ` [PATCH] " Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2008-08-08 0:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Thu, Aug 07, 2008 at 11:58:49PM +0200, Christoph Hellwig wrote:
> The dp to ip comment should be for the unconditional xfs_droplink
> call, and the "." link obviously only exists for directories,
> so it should be in the is_dir conditional.
Ack.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial xfs_remove comment fixup
2008-08-07 21:58 PATCH] trivial xfs_remove comment fixup Christoph Hellwig
2008-08-08 0:33 ` Dave Chinner
@ 2008-10-18 12:36 ` Christoph Hellwig
2008-10-21 7:36 ` Donald Douwsma
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2008-10-18 12:36 UTC (permalink / raw)
To: xfs
Ping? This is just a trivial comment fixup, shouldn't be that hard to
review..
On Thu, Aug 07, 2008 at 11:58:49PM +0200, Christoph Hellwig wrote:
> The dp to ip comment should be for the unconditional xfs_droplink
> call, and the "." link obviously only exists for directories,
> so it should be in the is_dir conditional.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_vnodeops.c 2008-08-06 17:26:37.000000000 -0300
> +++ linux-2.6-xfs/fs/xfs/xfs_vnodeops.c 2008-08-06 17:36:44.000000000 -0300
> @@ -2014,7 +2014,7 @@ xfs_remove(
> goto out_bmap_cancel;
>
> /*
> - * Drop the link from dp to ip.
> + * Drop the "." link from ip to self.
> */
> error = xfs_droplink(tp, ip);
> if (error)
> @@ -2029,7 +2029,7 @@ xfs_remove(
> }
>
> /*
> - * Drop the "." link from ip to self.
> + * Drop the link from dp to ip.
> */
> error = xfs_droplink(tp, ip);
> if (error)
---end quoted text---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] trivial xfs_remove comment fixup
2008-10-18 12:36 ` [PATCH] " Christoph Hellwig
@ 2008-10-21 7:36 ` Donald Douwsma
0 siblings, 0 replies; 4+ messages in thread
From: Donald Douwsma @ 2008-10-21 7:36 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> Ping? This is just a trivial comment fixup, shouldn't be that hard to
> review..
This is to cleanup the comments from the xfs_rmd -> xfs_remove merge.
Ok then, its in.
>
> On Thu, Aug 07, 2008 at 11:58:49PM +0200, Christoph Hellwig wrote:
>> The dp to ip comment should be for the unconditional xfs_droplink
>> call, and the "." link obviously only exists for directories,
>> so it should be in the is_dir conditional.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/xfs_vnodeops.c 2008-08-06 17:26:37.000000000 -0300
>> +++ linux-2.6-xfs/fs/xfs/xfs_vnodeops.c 2008-08-06 17:36:44.000000000 -0300
>> @@ -2014,7 +2014,7 @@ xfs_remove(
>> goto out_bmap_cancel;
>>
>> /*
>> - * Drop the link from dp to ip.
>> + * Drop the "." link from ip to self.
>> */
>> error = xfs_droplink(tp, ip);
>> if (error)
>> @@ -2029,7 +2029,7 @@ xfs_remove(
>> }
>>
>> /*
>> - * Drop the "." link from ip to self.
>> + * Drop the link from dp to ip.
>> */
>> error = xfs_droplink(tp, ip);
>> if (error)
> ---end quoted text---
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-21 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-07 21:58 PATCH] trivial xfs_remove comment fixup Christoph Hellwig
2008-08-08 0:33 ` Dave Chinner
2008-10-18 12:36 ` [PATCH] " Christoph Hellwig
2008-10-21 7:36 ` Donald Douwsma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox