From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
lachlan@sgi.com, xfs-dev@sgi.com, xfs@oss.sgi.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [REVIEW] Prevent direct I/O from mapping extents beyond eof
Date: Fri, 15 Aug 2008 18:40:47 -0400 [thread overview]
Message-ID: <20080815224047.GA15914@infradead.org> (raw)
In-Reply-To: <20080815152756.61aab5a7.akpm@linux-foundation.org>
On Fri, Aug 15, 2008 at 03:27:56PM -0700, Andrew Morton wrote:
> Oh gee, I forget, and so many people have done drivebys on that code...
>
> We _could_ add additional i_size checking into direct-io.c but bear in
> mind that it would be best-effort unreliable stuff. The code will
> still be tripped up by concurrent extends and concurrent truncates.
>
> So we'll still end up calling the fs for blocks outside i_size, only
> less commonly. I think.
Yeah, guess we should put in this patch then.
prev parent reply other threads:[~2008-08-15 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48A50152.8020104@sgi.com>
2008-08-15 22:09 ` [REVIEW] Prevent direct I/O from mapping extents beyond eof Christoph Hellwig
2008-08-15 22:27 ` Andrew Morton
2008-08-15 22:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815224047.GA15914@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=lachlan@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox