From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] XFS: Never call mark_inode_dirty_sync() directly
Date: Mon, 18 Aug 2008 10:19:35 +1000 [thread overview]
Message-ID: <20080818001935.GF19760@disturbed> (raw)
In-Reply-To: <20080814194702.GB12237@infradead.org>
On Thu, Aug 14, 2008 at 03:47:02PM -0400, Christoph Hellwig wrote:
> On Thu, Aug 14, 2008 at 05:14:40PM +1000, Dave Chinner wrote:
> > Once the Linux inode and the XFS inode are combined, we cannot rely
> > on just check if the linux inode exists as a method of determining
> > if it is valid or not. Hence we should always call
> > xfs_mark_inode_dirty_sync() instead as it does the correct checks to
> > determine if the liinux inode is in a valid state or not.
>
> Makes sense, and another candidate to put at the beginning of the series
> or rather just put in now.
Ok. I'll reorder it...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-08-18 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1218698083-11226-1-git-send-email-david@fromorbit.com>
[not found] ` <1218698083-11226-6-git-send-email-david@fromorbit.com>
[not found] ` <20080814190001.GA19070@infradead.org>
2008-08-18 0:19 ` [PATCH 5/7] XFS: Make use of the init-once slab optimisation Dave Chinner
[not found] ` <1218698083-11226-5-git-send-email-david@fromorbit.com>
[not found] ` <20080814194702.GB12237@infradead.org>
2008-08-18 0:19 ` Dave Chinner [this message]
[not found] ` <1218698083-11226-7-git-send-email-david@fromorbit.com>
[not found] ` <20080814200006.GC12237@infradead.org>
2008-08-18 0:34 ` [PATCH 6/7] XFS: Combine the XFS and Linux inodes Dave Chinner
[not found] ` <1218698083-11226-8-git-send-email-david@fromorbit.com>
[not found] ` <20080814201022.GA20557@infradead.org>
2008-08-18 0:42 ` [PATCH 7/7] XFS: don't use vnodes where unnecessary Dave Chinner
[not found] ` <20080814194550.GA12237@infradead.org>
2008-08-18 1:13 ` [PATCH 0/7] RFC: combine linux and XFS inodes Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818001935.GF19760@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox