From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: REVIEW: Remove convert_extent function in xfs_repair
Date: Tue, 26 Aug 2008 15:15:47 -0400 [thread overview]
Message-ID: <20080826191547.GA6638@infradead.org> (raw)
In-Reply-To: <op.ugg16sju3jf8g2@pc-bnaujok.melbourne.sgi.com>
On Tue, Aug 26, 2008 at 12:21:54PM +1000, Barry Naujok wrote:
> It seems convert_extent is not that useful, so remove it and call
> libxfs_bmbt_disk_get_all() directly and use the xfs_bmbt_irec_t
> structure directly.
Yes, the new code is much more readable. The patch looks good to m.
prev parent reply other threads:[~2008-08-26 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 2:21 REVIEW: Remove convert_extent function in xfs_repair Barry Naujok
2008-08-26 19:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826191547.GA6638@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox