From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs)
Date: Sun, 31 Aug 2008 21:59:50 -0400 [thread overview]
Message-ID: <20080901015950.GA16825@infradead.org> (raw)
In-Reply-To: <op.ugr4zpyv3jf8g2@pc-bnaujok.melbourne.sgi.com>
On Mon, Sep 01, 2008 at 11:56:03AM +1000, Barry Naujok wrote:
> On Sat, 30 Aug 2008 04:11:20 +1000, Christoph Hellwig <hch@infradead.org>
> wrote:
>
>> On Fri, Aug 29, 2008 at 05:59:43PM +1000, Barry Naujok wrote:
>>> On Fri, 29 Aug 2008 17:00:56 +1000, Barry Naujok <bnaujok@sgi.com>
>>> wrote:
>>>
>>>> Mostly header changes associated with #ifdef __KERNEL__ stuff.
>>>>
>>>> Some function prototypes had to be reordered to separate
>>>> shared and kernel only functions.
>>>
>>> fs/xfs/xfs_inode.h patch looked pretty horrid (and there was a missing
>>> declaration), here's a better version:
>>
>> I still don't like it very much :) What about just moving the
>> xfs_ictimestamp and xfs_icdinode defintions next to the ifork
>> so that we can save one ifdef __KERNEL__? Also might be worth
>> to move the xfs_iflock & co inlines before the end of that __KERNEL__
>> block to save another ifdef.
>
> Ok, this now only has one blob of #ifdef __KERNEL__ in it now:
Looks good.
next prev parent reply other threads:[~2008-09-01 1:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 7:00 [REVIEW #2] Update kernel code to compile in userspace (libxfs) Barry Naujok
2008-08-29 7:59 ` Barry Naujok
2008-08-29 18:11 ` Christoph Hellwig
2008-09-01 1:56 ` Barry Naujok
2008-09-01 1:59 ` Christoph Hellwig [this message]
2008-09-01 2:06 ` Barry Naujok
2008-09-01 2:08 ` Christoph Hellwig
2008-09-01 4:55 ` Barry Naujok
2008-09-01 5:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901015950.GA16825@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox