From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs)
Date: Mon, 1 Sep 2008 01:00:45 -0400 [thread overview]
Message-ID: <20080901050045.GA1396@infradead.org> (raw)
In-Reply-To: <op.ugsdamyd3jf8g2@pc-bnaujok.melbourne.sgi.com>
> --- 2.6.x-xfs.orig/fs/xfs/xfs_ag.h
> +++ 2.6.x-xfs/fs/xfs/xfs_ag.h
> @@ -192,15 +192,16 @@ typedef struct xfs_perag
> xfs_agino_t pagi_freecount; /* number of free inodes */
> xfs_agino_t pagi_count; /* number of allocated inodes */
> int pagb_count; /* pagb slots in use */
> + xfs_perag_busy_t *pagb_list; /* unstable blocks */
> #ifdef __KERNEL__
> spinlock_t pagb_lock; /* lock for pagb_list */
> -#endif
> - xfs_perag_busy_t *pagb_list; /* unstable blocks */
> +
Inside structures we should be more careful about reordering,
but this one looks fine becaus pagb_list and pagb_lock should
be in the same cache line either way.
The rest looks good, too.
prev parent reply other threads:[~2008-09-01 5:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 7:00 [REVIEW #2] Update kernel code to compile in userspace (libxfs) Barry Naujok
2008-08-29 7:59 ` Barry Naujok
2008-08-29 18:11 ` Christoph Hellwig
2008-09-01 1:56 ` Barry Naujok
2008-09-01 1:59 ` Christoph Hellwig
2008-09-01 2:06 ` Barry Naujok
2008-09-01 2:08 ` Christoph Hellwig
2008-09-01 4:55 ` Barry Naujok
2008-09-01 5:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901050045.GA1396@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox