From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Tweak tracing allocation sizes
Date: Tue, 2 Sep 2008 15:56:04 +1000 [thread overview]
Message-ID: <20080902055604.GD15962@disturbed> (raw)
In-Reply-To: <48BCD3BE.5040107@sgi.com>
On Tue, Sep 02, 2008 at 03:48:46PM +1000, Lachlan McIlroy wrote:
> The size of a single ktrace entry is 16 pointers so 128 bytes. For the case
> of XFS_RW_KTRACE_SIZE which is 128 entries this equates to 16KB and on a system
> with 4KB pages that is under memory pressure this can stall that process for a
> significant time while it hunts for 4 free pages. Cutting this value back to
> 32 means it will only need one page.
That will effectively render that type of tracing useless - 32
entries is not enough history to capture enough
read/write/map/invalidate trace events to be meaningful. In the past
I've often had to increase this to 256 or 512 entries to be able to
capture the events necessary to debug problems...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-09-02 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 5:48 [PATCH] Tweak tracing allocation sizes Lachlan McIlroy
2008-09-02 5:56 ` Dave Chinner [this message]
2008-09-02 6:12 ` Lachlan McIlroy
2008-09-02 6:27 ` Dave Chinner
2008-09-02 21:54 ` Christoph Hellwig
2008-09-02 6:50 ` Andi Kleen
2008-09-02 21:55 ` Christoph Hellwig
2008-09-03 7:06 ` Andi Kleen
2008-09-03 12:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902055604.GD15962@disturbed \
--to=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox