From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Don't do I/O beyond eof when unreserving space
Date: Tue, 2 Sep 2008 17:51:57 -0400 [thread overview]
Message-ID: <20080902215157.GC9204@infradead.org> (raw)
In-Reply-To: <48BCCE29.3070707@sgi.com>
On Tue, Sep 02, 2008 at 03:24:57PM +1000, Lachlan McIlroy wrote:
> When unreserving space with boundaries that are not block aligned we round
> up the start and round down the end boundaries and then use this function,
> xfs_zero_remaining_bytes(), to zero the parts of the blocks that got dropped
> during the rounding. The problem is we don't consider if these blocks are
> beyond eof. Worse still is if we encounter delayed allocations beyond eof
> we will try to use the magic delayed allocation block number as a real block
> number. If the file size is ever extended to expose these blocks then we'll
> go through xfs_zero_eof() to zero them anyway.
Makes sense. Would be nice to have a comment above the check explaining
why these first strange checks are there. Something like the first
setence of the patch description here.
prev parent reply other threads:[~2008-09-02 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 5:24 [PATCH] Don't do I/O beyond eof when unreserving space Lachlan McIlroy
2008-09-02 21:51 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080902215157.GC9204@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox