From: Dave Chinner <david@fromorbit.com>
To: Barry Naujok <bnaujok@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: REVIEW: Zero rest of superblock sector always
Date: Thu, 4 Sep 2008 09:12:20 +1000 [thread overview]
Message-ID: <20080903231220.GB15950@disturbed> (raw)
In-Reply-To: <op.ugv7zt013jf8g2@pc-bnaujok.melbourne.sgi.com>
On Wed, Sep 03, 2008 at 04:51:19PM +1000, Barry Naujok wrote:
> I found that zeroing the "garbage" beyond the end of the superblock in
> the first sector of each AG rather inconsistant. It depended on some
> obscure combination of version bits to be set.
Just for filling out hte history, that isfixing a bug in an old, old
mkfs.xfs on Irix where a certain version failed to zero the
superblock(s) before initialising them. Every XFS filesystem made in
the last 10 years should have properly initialised superblocks.
But still, doing it unconditionally is fine as it will fix stuff
like fsfuzzer damage....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-09-03 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 6:51 REVIEW: Zero rest of superblock sector always Barry Naujok
2008-09-03 6:52 ` Barry Naujok
2008-09-03 12:18 ` Christoph Hellwig
2008-09-03 23:12 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903231220.GB15950@disturbed \
--to=david@fromorbit.com \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox