From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: REVIEW: Improve caching in libxfs
Date: Thu, 4 Sep 2008 14:40:14 -0400 [thread overview]
Message-ID: <20080904184014.GB25890@infradead.org> (raw)
In-Reply-To: <op.ugx0d0i83jf8g2@pc-bnaujok.melbourne.sgi.com>
On Thu, Sep 04, 2008 at 04:02:14PM +1000, Barry Naujok wrote:
>> Assert that we don't put a node that's already on the mru list, okay.
>> Shouldn't this be ASSERT?
>
> I chose to make this always abort as it can be triggered outside of
> libxfs by xfsprogs usage of it (ie. doing a "put" on a buffer that has
> already been "put").
>
> So, I thought this needs to always work, debug or non-debug and
> halt immediately if it happens.
Ok, makes sense.
prev parent reply other threads:[~2008-09-04 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 6:38 REVIEW: Improve caching in libxfs Barry Naujok
2008-09-03 23:47 ` Christoph Hellwig
2008-09-04 5:56 ` Barry Naujok
2008-09-04 18:39 ` Christoph Hellwig
2008-09-04 6:02 ` Barry Naujok
2008-09-04 18:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904184014.GB25890@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox