public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ed Cashin <ecashin@coraid.com>
To: xfs@oss.sgi.com, Adrian Bunk <bunk@kernel.org>
Subject: Re: xfs_growfs fix backport for 2.6.16.y
Date: Fri, 5 Sep 2008 12:29:21 -0400	[thread overview]
Message-ID: <20080905162921.GA8000@coraid.com> (raw)
In-Reply-To: <20080904231418.GB5991@disturbed>

On Fri, Sep 05, 2008 at 09:14:18AM +1000, Dave Chinner wrote:
...
> Ah, yes. That. I think Barry can try to explain that one because:
> 
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-cmds/xfstests/078.out.diff?r1=1.3;r2=1.4
> 
> The test golden output was changed instead of someone understanding
> why the fixes to growfs changed the size that the filesystem was
> grown to. ISTR being opposed to changing the golden output because
> it was the wrong thing to do and would break QA on older kernels,
> not to mention that it indicated some possible off-by-one bug in
> a change that had been made at some point...
> 
> Other than that, the backport should be fine given it passed all the
> other parts of the test....

Oh, that's good news, thanks.

I just need to test the patch on a 32-bit O.S. now, but
I am having a difficult time building xfs-cmds/xfstests
on a CentOS 5 VM.

Does anyone have a recommendation for an O.S. I can use
to build and run the xfsqa test 078?  It would be running
the 2.6.16.62 kernel with the patch in question, not the
stock distro kernel.

-- 
  Ed Cashin <ecashin@coraid.com>

      reply	other threads:[~2008-09-05 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25 15:39 xfs_growfs fix backport for 2.6.16.y Ed Cashin
2008-08-26  2:01 ` Dave Chinner
2008-09-03 18:27   ` Ed Cashin
2008-09-04 23:14     ` Dave Chinner
2008-09-05 16:29       ` Ed Cashin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080905162921.GA8000@coraid.com \
    --to=ecashin@coraid.com \
    --cc=bunk@kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox