From: Christoph Hellwig <hch@infradead.org>
To: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync
Date: Sun, 14 Sep 2008 09:23:13 -0400 [thread overview]
Message-ID: <20080914132313.GC14266@infradead.org> (raw)
In-Reply-To: <20080913203549.GK5811@disturbed>
On Sun, Sep 14, 2008 at 06:35:49AM +1000, Dave Chinner wrote:
> On Sat, Sep 13, 2008 at 12:58:56PM -0400, Josef 'Jeff' Sipek wrote:
> > On Sat, Sep 13, 2008 at 11:57:05PM +1000, Dave Chinner wrote:
> > ...
> > > @@ -533,8 +538,15 @@ xfs_sync_worker(
> > > {
> > > int error;
> > >
> > > - if (!(mp->m_flags & XFS_MOUNT_RDONLY))
> > > - error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR);
> > > + if (!(mp->m_flags & XFS_MOUNT_RDONLY)) {
> > > + xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE);
> > > + xfs_finish_reclaim_all(mp, 1, XFS_IFLUSH_DELWRI_ELSE_ASYNC);
> > > + /* dgc: errors ignored here */
> >
> > Again, why?
>
> Same again. No context for returning an error to someone useful,
> and will only fail in a shutdown situation.
We should probably put this is as comment her and in the previous spot
to avoid this question coming up again.
next prev parent reply other threads:[~2008-09-14 13:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 13:57 [PATCH 0/10] XFS: clean up sync code Dave Chinner
2008-09-13 13:57 ` [PATCH 01/10] XFS: split out two helpers from xfs_syncsub Dave Chinner
2008-09-13 16:53 ` Josef 'Jeff' Sipek
2008-09-13 20:34 ` Dave Chinner
2008-09-13 13:57 ` [PATCH 02/10] XFS: Use struct inodes instead of vnodes to kill vn_grab Dave Chinner
2008-09-13 13:57 ` [PATCH 03/10] XFS: use xfs_sync_inodes rather than xfs_syncsub Dave Chinner
2008-09-13 13:57 ` [PATCH 04/10] XFS: kill xfs_syncsub Dave Chinner
2008-09-13 13:57 ` [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync Dave Chinner
2008-09-13 16:58 ` Josef 'Jeff' Sipek
2008-09-13 20:35 ` Dave Chinner
2008-09-14 13:23 ` Christoph Hellwig [this message]
2008-09-13 13:57 ` [PATCH 06/10] XFS: make SYNC_ATTR no longer use xfs_sync Dave Chinner
2008-09-13 13:57 ` [PATCH 07/10] XFS: make SYNC_DELWRI no longer use xfs_sync V2 Dave Chinner
2008-09-13 13:57 ` [PATCH 08/10] XFS: Kill SYNC_CLOSE Dave Chinner
2008-09-13 13:57 ` [PATCH 09/10] XFS: Kill xfs_sync() Dave Chinner
2008-09-13 13:57 ` [PATCH 10/10] XFS: Move remaining quiesce code Dave Chinner
2008-09-14 13:24 ` [PATCH 0/10] XFS: clean up sync code Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2008-10-07 21:43 Dave Chinner
2008-10-07 21:43 ` [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080914132313.GC14266@infradead.org \
--to=hch@infradead.org \
--cc=jeffpc@josefsipek.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox