From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] XFS: Never call mark_inode_dirty_sync() directly
Date: Mon, 15 Sep 2008 17:11:36 -0400 [thread overview]
Message-ID: <20080915211136.GB29743@infradead.org> (raw)
In-Reply-To: <1221314627-29065-4-git-send-email-david@fromorbit.com>
On Sun, Sep 14, 2008 at 12:03:47AM +1000, Dave Chinner wrote:
> Once the Linux inode and the XFS inode are combined, we cannot rely
> on just check if the linux inode exists as a method of determining
> if it is valid or not. Hence we should always call
> xfs_mark_inode_dirty_sync() instead as it does the correct checks to
> determine if the liinux inode is in a valid state or not.
Looks good.
prev parent reply other threads:[~2008-09-15 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 14:03 [PATCH 0/3] XFS: Prepare for combining the XFS and Linux inodes Dave Chinner
2008-09-13 14:03 ` [PATCH 1/3] XFS: factor xfs_iget_core() into hit and miss cases Dave Chinner
2008-09-15 21:12 ` Christoph Hellwig
2008-09-13 14:03 ` [PATCH 2/3] XFS: Make use of the init-once slab optimisation Dave Chinner
2008-09-15 21:11 ` Christoph Hellwig
2008-09-16 4:21 ` Dave Chinner
2008-09-13 14:03 ` [PATCH 3/3] XFS: Never call mark_inode_dirty_sync() directly Dave Chinner
2008-09-15 21:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915211136.GB29743@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox