From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] XFS: Make use of the init-once slab optimisation.
Date: Tue, 16 Sep 2008 14:21:05 +1000 [thread overview]
Message-ID: <20080916042105.GP5811@disturbed> (raw)
In-Reply-To: <20080915211117.GA29743@infradead.org>
On Mon, Sep 15, 2008 at 05:11:17PM -0400, Christoph Hellwig wrote:
> On Sun, Sep 14, 2008 at 12:03:46AM +1000, Dave Chinner wrote:
> > To avoid having to initialise some fields of the XFS inode
> > on every allocation, we can use the slab init-once feature
> > to initialise them. All we have to guarantee is that when
> > we free the inode, all it's entries are in the initial state.
> > Add asserts where possible to ensure debug kernels check this
> > initial state before freeing and after allocation.
>
> This looks like it's already in:
> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xaiki/xfs-linux-2.6-xfs-cvs/.git;a=commitdiff;h=12efb888674600ce73a64f8c6f4a20ea5e1ce4f1
<sigh>
Which means that some of the patches won't apply. SGI folks,
can you please get the master tree updated so I can rediff all
the patches and repost them again?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-09-16 4:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 14:03 [PATCH 0/3] XFS: Prepare for combining the XFS and Linux inodes Dave Chinner
2008-09-13 14:03 ` [PATCH 1/3] XFS: factor xfs_iget_core() into hit and miss cases Dave Chinner
2008-09-15 21:12 ` Christoph Hellwig
2008-09-13 14:03 ` [PATCH 2/3] XFS: Make use of the init-once slab optimisation Dave Chinner
2008-09-15 21:11 ` Christoph Hellwig
2008-09-16 4:21 ` Dave Chinner [this message]
2008-09-13 14:03 ` [PATCH 3/3] XFS: Never call mark_inode_dirty_sync() directly Dave Chinner
2008-09-15 21:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916042105.GP5811@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox