From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] XFS: rename inode reclaim functions
Date: Tue, 16 Sep 2008 14:27:53 +1000 [thread overview]
Message-ID: <20080916042753.GR5811@disturbed> (raw)
In-Reply-To: <20080915211400.GE29743@infradead.org>
On Mon, Sep 15, 2008 at 05:14:00PM -0400, Christoph Hellwig wrote:
> On Sun, Sep 14, 2008 at 12:14:57AM +1000, Dave Chinner wrote:
> > The function names xfs_finish_reclaim and xfs_finish_reclaim_all
> > are not very descriptive of what they are reclaiming. Rename to
> > xfs_reclaim_inode[s] to match the xfs_sync_inodes() function.
>
> Looks good, but in case you respin the series I'd move to this to
> number two in the series.
I can do that, though I'm getting pretty sick of this whole patch
set by now....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-09-16 4:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 14:14 [PATCH 0/6] XFS: Track reclaimable inodes in inode cache Dave Chinner
2008-09-13 14:14 ` [PATCH 1/6] XFS: move inode reclaim functions to xfs_sync.c Dave Chinner
2008-09-15 21:13 ` Christoph Hellwig
2008-09-13 14:14 ` [PATCH 2/6] XFS: mark inodes for reclaim via a tag in the inode radix tree Dave Chinner
2008-09-15 21:14 ` Christoph Hellwig
2008-09-16 4:26 ` Dave Chinner
2008-09-13 14:14 ` [PATCH 3/6] XFS: rename inode reclaim functions Dave Chinner
2008-09-15 21:14 ` Christoph Hellwig
2008-09-16 4:27 ` Dave Chinner [this message]
2008-09-13 14:14 ` [PATCH 4/6] XFS: use the inode radix tree for reclaiming inodes Dave Chinner
2008-09-15 21:15 ` Christoph Hellwig
2008-09-13 14:14 ` [PATCH 5/6] XFS: kill deleted inodes list Dave Chinner
2008-09-15 21:17 ` Christoph Hellwig
2008-09-13 14:15 ` [PATCH 6/6] XFS: use is_bad_inode() directly in xfs_reclaim_inode() Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916042753.GR5811@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox