From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] cleanup maxrecs calculation
Date: Tue, 16 Sep 2008 15:36:41 +1000 [thread overview]
Message-ID: <20080916053641.GV5811@disturbed> (raw)
In-Reply-To: <20080915004648.GD12213@lst.de>
On Mon, Sep 15, 2008 at 02:46:48AM +0200, Christoph Hellwig wrote:
> + mp->m_alloc_mxr[0] = xfs_allocbt_maxrecs(mp, sbp->sb_blocksize, 1);
> + mp->m_alloc_mxr[1] = xfs_allocbt_maxrecs(mp, sbp->sb_blocksize, 0);
That's kind of strange - index 0 gets configured with a leaf (?)
value of 1, and index 1 with a value of 0. Can we change the order
of one of these so that the function and the variables match?
Would a define for what the function parameter means make sense?
That way the code would document itself....
> @@ -650,7 +650,8 @@ xfs_iformat_btree(
> * Copy and convert from the on-disk structure
> * to the in-memory structure.
> */
> - xfs_bmdr_to_bmbt(dfp, XFS_DFORK_SIZE(dip, ip->i_mount, whichfork),
> + xfs_bmdr_to_bmbt(ip->i_mount, dfp,
> + XFS_DFORK_SIZE(dip, ip->i_mount, whichfork),
> ifp->if_broot, size);
Indenting could do with some fixing there.
Otherwise looks good.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-09-16 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 0:46 [PATCH 3/6] cleanup maxrecs calculation Christoph Hellwig
2008-09-16 5:36 ` Dave Chinner [this message]
2008-09-16 17:29 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2008-09-22 11:06 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916053641.GV5811@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox