From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/6] cleanup btree record / key / ptr addressing macros
Date: Wed, 17 Sep 2008 10:57:50 +1000 [thread overview]
Message-ID: <20080917005750.GG5811@disturbed> (raw)
In-Reply-To: <20080916174136.GC26187@lst.de>
On Tue, Sep 16, 2008 at 07:41:36PM +0200, Christoph Hellwig wrote:
> On Tue, Sep 16, 2008 at 03:53:33PM +1000, Dave Chinner wrote:
> > On Mon, Sep 15, 2008 at 02:46:53AM +0200, Christoph Hellwig wrote:
> > > +#define XFS_BMAP_BROOT_PTR_ADDR(mp, bb, i, sz) \
> > > + XFS_BMBT_PTR_ADDR(mp, bb, i, xfs_bmbt_maxrecs(mp, sz, 0))
> >
> > Ah, that explains why that macro didn't change. Why keep just this
> > one?
>
> It seems borderline useful, but if you care strongly I can kill it.
I don't really mind - i was just curious as to why that particular
macro didn't get changed like all the others. Seems reasonable to
leave it there....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-09-17 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 0:46 [PATCH 4/6] cleanup btree record / key / ptr addressing macros Christoph Hellwig
2008-09-16 5:53 ` Dave Chinner
2008-09-16 17:41 ` Christoph Hellwig
2008-09-17 0:57 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-22 11:06 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917005750.GG5811@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox