From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com, toei.rei@stargazer.at
Subject: Re: [PATCH] fix barrier fail detection
Date: Fri, 10 Oct 2008 09:35:34 +1100 [thread overview]
Message-ID: <20081009223534.GJ9597@disturbed> (raw)
In-Reply-To: <20081009130042.GA21071@lst.de>
On Thu, Oct 09, 2008 at 03:00:42PM +0200, Christoph Hellwig wrote:
> Currently we disable barriers as soon as we get a buffer in xlog_iodone
> that has the XBF_ORDERED flag cleared. But this can be the case not only
> for buffers where the barrier failed, but also the first buffer of a
> split log write in case of a log wraparound. Due to the disabled
> barriers we can easily get directory corruption on unclean shutdowns.
> So instead of using this check add a new buffer flag for failed barrier
> writes.
>
> This is a regression vs 2.6.26 caused by patch to use the right macro
> to check for the ORDERED flag, as we previously got true returned for
> every buffer.
>
> Thanks to Toei Rei for reporting the bug.
Looks good. Should this be sent straight to Linus to get it into
.27? If you want to do that, you can add my SOB.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-09 22:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 13:00 [PATCH] fix barrier fail detection Christoph Hellwig
2008-10-09 14:24 ` Eric Sandeen
2008-10-09 22:35 ` Dave Chinner [this message]
2008-10-10 0:43 ` Christoph Hellwig
2008-10-10 0:44 ` Timothy Shimmin
2008-10-10 1:12 ` Timothy Shimmin
2008-10-10 4:17 ` Timothy Shimmin
2008-10-10 4:27 ` Dave Chinner
2008-10-10 9:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009223534.GJ9597@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=toei.rei@stargazer.at \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox