Re: [PATCH] fix remount rw with unrecognized options

Christoph Hellwig
2008-10-12T22:19:04Z

On Sun, Oct 12, 2008 at 05:19:51PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > When we skip unrecognized options in xfs_fs_remount we should just break
> > out of the switch and not return because otherwise we may skip clearing
> > the xfs-internal read-only flag. This will only show up on some
> > operations like touch because most read-only checks are done by the VFS
> > which things this filesystem is r/w. Eventually we should replace the
> > XFS read-only flag with a helper that always checks the VFS flag to make
> > sure they can never get out of sync.
> >
> > Bug reported and fix verified by Marcel Beister on #xfs.
>
> Seems reasonable.
>
> I think this is 2.6.27.1 material?

Yes.