public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: Attribution of patches in the git tree...
Date: Wed, 15 Oct 2008 12:32:06 +1100	[thread overview]
Message-ID: <20081015013206.GT10716@disturbed> (raw)

Folks,

Just noticed that all the btree factoring patches in the
master tree are attributed to Christoph, even when his patch
descriptions gave a different attribution for the source of the
patch. e.g:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=commit;h=ea8fb246ad5230263f13e45635fad80cc04e28a0

> [XFS] implement generic xfs_btree_increment
>
> From: Dave Chinner <dgc@sgi.com>
>
> Because this is the first major generic btree routine this patch includes
> some infrastrucure, first a few routines to deal with a btree block that
> can be either in short or long form, second xfs_btree_read_buf_block,
> which is the new central routine to read a btree block given a cursor, and
> third the new xfs_btree_ptr_addr routine to calculate the address for a
> given btree pointer record.

The description has a "From: blah" line indicates the author
of the patch was not the person who sent the patch. i.e. the git
"author" is incorrect, and the only way to find that out is by
looking at the commit description.

In future, can we please get the attribution for patches correct
in the git tree so that things like pull requests and historical
mining of the trees accurately reflect who the author of the patches
really are?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

                 reply	other threads:[~2008-10-15  1:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081015013206.GT10716@disturbed \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox