public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* Attribution of patches in the git tree...
@ 2008-10-15  1:32 Dave Chinner
  0 siblings, 0 replies; only message in thread
From: Dave Chinner @ 2008-10-15  1:32 UTC (permalink / raw)
  To: xfs

Folks,

Just noticed that all the btree factoring patches in the
master tree are attributed to Christoph, even when his patch
descriptions gave a different attribution for the source of the
patch. e.g:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=commit;h=ea8fb246ad5230263f13e45635fad80cc04e28a0

> [XFS] implement generic xfs_btree_increment
>
> From: Dave Chinner <dgc@sgi.com>
>
> Because this is the first major generic btree routine this patch includes
> some infrastrucure, first a few routines to deal with a btree block that
> can be either in short or long form, second xfs_btree_read_buf_block,
> which is the new central routine to read a btree block given a cursor, and
> third the new xfs_btree_ptr_addr routine to calculate the address for a
> given btree pointer record.

The description has a "From: blah" line indicates the author
of the patch was not the person who sent the patch. i.e. the git
"author" is incorrect, and the only way to find that out is by
looking at the commit description.

In future, can we please get the attribution for patches correct
in the git tree so that things like pull requests and historical
mining of the trees accurately reflect who the author of the patches
really are?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-10-15  1:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-15  1:32 Attribution of patches in the git tree Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox