From: Christoph Hellwig <hch@infradead.org>
To: Peter Leckie <pleckie@sgi.com>, xfs@oss.sgi.com
Subject: Re: crash with latest code drop.
Date: Tue, 14 Oct 2008 22:29:49 -0400 [thread overview]
Message-ID: <20081015022948.GA20966@infradead.org> (raw)
In-Reply-To: <20081015011857.GS10716@disturbed>
> + * in reclaim. Leave it for the reclaim code to flush.
> */
> if (igrab(inode)) {
> read_unlock(&pag->pag_ici_lock);
> xfs_ilock(ip, lock_flags);
> } else {
> + /* leave it to reclaim */
> read_unlock(&pag->pag_ici_lock);
> + continue;
> }
Might be betters as
if (!igrab(inode)) {
/* leave it to reclaim */
read_unlock(&pag->pag_ici_lock);
continue;
}
read_unlock(&pag->pag_ici_lock);
xfs_ilock(ip, lock_flags);
which then also shows that we could stop doing the ilock at all for
the DELWRI case, thas is after fixing the last caller doing
SYNC_ATTR|SYNC_DELWRI. Well yeah, lots of things still to sort out in
this area.
next prev parent reply other threads:[~2008-10-15 2:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 1:49 crash with latest code drop Peter Leckie
2008-10-15 1:18 ` Dave Chinner
2008-10-15 2:29 ` Christoph Hellwig [this message]
2008-10-15 3:16 ` Dave Chinner
2008-10-15 3:24 ` Christoph Hellwig
2008-10-15 3:51 ` Dave Chinner
2008-10-15 5:50 ` Peter Leckie
2008-10-15 6:19 ` Dave Chinner
2008-10-15 7:51 ` Peter Leckie
2008-10-16 2:43 ` Peter Leckie
2008-10-16 5:55 ` Dave Chinner
2008-10-16 9:00 ` Christoph Hellwig
2008-10-17 1:01 ` Lachlan McIlroy
2008-10-22 6:19 ` Dave Chinner
2008-10-23 4:23 ` Peter Leckie
2008-10-23 5:39 ` Dave Chinner
2008-10-15 3:47 ` Peter Leckie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015022948.GA20966@infradead.org \
--to=hch@infradead.org \
--cc=pleckie@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox