TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Lachlan McIlroy]

Fix build error - use VFS_I() to access linux inode from xfs inode

Date:  Wed Oct 15 13:10:35 EST 2008
Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-inode
Inspected by:  lachlan
Author:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:32326a
fs/xfs/dmapi/xfs_dm.c - 1.79 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/dmapi/xfs_dm.c.diff?r1=text&tr1=1.79&r2=text&tr2=1.78&f=h
	- Fix build error - use VFS_I() to access linux inode from xfs inode

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Christoph Hellwig]

FYI I sent this patch out first on 22nd of August, and pinged it on 29th
of Semptember..

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Christoph Hellwig]

On Wed, Oct 15, 2008 at 01:36:46PM +1000, Lachlan McIlroy wrote:
> Sorry Christoph.  I just don't have time to read all posts.
>
> I expect fixes to be in the same patch series that breaks the code - it
> didn't occur to me to go looking for a fix on OSS.

Well, Daven unfortunately can't be bothered to use the same tree as
everyone else.  But I made it pretty clear in the patch that it is
needed for the series when using a ptools/cvs style tree, and that it's
harmless to apply it ASAP even without those bits.

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Christoph Hellwig]

On Wed, Oct 15, 2008 at 01:49:56PM +1000, Lachlan McIlroy wrote:
> We really appreciate you using the cvs tree and keeping all the non-
> mainline stuff up to date and working.  If you like I'll credit you for
> the patch when I push it to OSS.

I don't care much about the credit.  It's just annoying that the thing
first broke and had to be fixed and wasted your time just because
patches get lost all the time.

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Russell Cattelan]

Mark Goodwin wrote:
>
>
> Christoph Hellwig wrote:
>> FYI I sent this patch out first on 22nd of August, and pinged it on 29th
>> of Semptember..
>
> Thus is why we need something like 'patchworks' hooked into the xfs@oss
> list - better tracking of patch submissions and their status.
So what is patchworks?

>
> Cheers
> -- Mark
>

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Mark Goodwin]

Christoph Hellwig wrote:
> FYI I sent this patch out first on 22nd of August, and pinged it on 29th
> of Semptember..

Thus is why we need something like 'patchworks' hooked into the xfs@oss
list - better tracking of patch submissions and their status.

Cheers
-- Mark

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Lachlan McIlroy]

Sorry Christoph.  I just don't have time to read all posts.

I expect fixes to be in the same patch series that breaks the code - it
didn't occur to me to go looking for a fix on OSS.

Christoph Hellwig wrote:
> FYI I sent this patch out first on 22nd of August, and pinged it on 29th
> of Semptember..
> 
> 
> 

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Lachlan McIlroy]

Christoph Hellwig wrote:
> On Wed, Oct 15, 2008 at 01:36:46PM +1000, Lachlan McIlroy wrote:
>> Sorry Christoph.  I just don't have time to read all posts.
>>
>> I expect fixes to be in the same patch series that breaks the code - it
>> didn't occur to me to go looking for a fix on OSS.
> 
> Well, Daven unfortunately can't be bothered to use the same tree as
> everyone else.  But I made it pretty clear in the patch that it is
> needed for the series when using a ptools/cvs style tree, and that it's
> harmless to apply it ASAP even without those bits.

We really appreciate you using the cvs tree and keeping all the non-
mainline stuff up to date and working.  If you like I'll credit you for
the patch when I push it to OSS.

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux inode from xfs inode

[Mark Goodwin]

Russell Cattelan wrote:
> Mark Goodwin wrote:
>>
>>
>> Christoph Hellwig wrote:
>>> FYI I sent this patch out first on 22nd of August, and pinged it on 29th
>>> of Semptember..
>>
>> Thus is why we need something like 'patchworks' hooked into the xfs@oss
>> list - better tracking of patch submissions and their status.
> So what is patchworks?

It's a patch submission tracking system for project mailing lists
such as xfs@oss. See http://ozlabs.org/~jk/projects/patchwork

-- Mark

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux?inode from xfs inode

[Mark Goodwin]

Jeremy Kerr wrote:
> Hi Christoph,
> 
>> Any progress on setting up a patchworks project for the xfs list?
> 
> I'm still waiting for someone to reply to my previous request:

oh sorry, I missed that request.

> 
>> Also, I need the following to set up the patchworks project:
>>
>>  * The List-ID (or X-Mailing-List) header added to list messages
>>  * The mailing list address.
>>
>> Alternatively, just forward me a message that's been through the
>> list.

I've changed cc: in this reply from xfs-dev@sgi.com to xfs@oss.sgi.com

Thanks

> 
> Cheers,
> 
> 
> Jeremy

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux?inode from xfs inode

[Jeremy Kerr]

Hi all,

> > I'm still waiting for someone to reply to my previous request:
>
> oh sorry, I missed that request.

Do you guys still want a patchwork setup? If so, I'm still waiting on 
this:

> >> Also, I need the following to set up the patchworks project:
> >>
> >>  * The List-ID (or X-Mailing-List) header added to list messages
> >>  * The mailing list address.
> >>
> >> Alternatively, just forward me a message that's been through the
> >> list.

Cheers,


Jeremy

Re: TAKE 988141 - Fix build error - use VFS_I() to access linux?inode from xfs inode

[Mark Goodwin]

Jeremy Kerr wrote:
> Hi all,
> 
>>> I'm still waiting for someone to reply to my previous request:
>> oh sorry, I missed that request.
> 
> Do you guys still want a patchwork setup?

No, we've got patchwork set up on xfs.org for now, thanks anyway :)

Cheers

> If so, I'm still waiting on
> this:
> 
>>>> Also, I need the following to set up the patchworks project:
>>>>
>>>>  * The List-ID (or X-Mailing-List) header added to list messages
>>>>  * The mailing list address.
>>>>
>>>> Alternatively, just forward me a message that's been through the
>>>> list.
> 
> Cheers,
> 
> 
> Jeremy

-- 

  Mark Goodwin                                  markgw@sgi.com
  Engineering Manager for XFS and PCP    Phone: +61-3-99631937
  SGI Australian Software Group           Cell: +61-4-18969583
-------------------------------------------------------------