From: Dave Chinner <david@fromorbit.com>
To: Peter Leckie <pleckie@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: crash with latest code drop.
Date: Thu, 16 Oct 2008 16:55:30 +1100 [thread overview]
Message-ID: <20081016055530.GE25906@disturbed> (raw)
In-Reply-To: <48F6AA3E.8030902@sgi.com>
On Thu, Oct 16, 2008 at 12:43:10PM +1000, Peter Leckie wrote:
>
>>> - it's the same as
>>> the first report - deferencing the linux inode without first having
>>> a refernce on it.
>>>
>>
>> Yes it resolves the issue.
>
> I spoke to soon, Ooops as follows:
....
> Adding the following resolved the issue however you may wish to solve it
> in another manner.
>
> @@ -102,7 +102,7 @@ xfs_sync_inodes_ag(
> * in reclaim. Leave it for the reclaim code to flush.
> */
> inode = VFS_I(ip);
> - if (!igrab(inode)) {
> + if (!inode || !igrab(inode)) {
> read_unlock(&pag->pag_ici_lock);
> continue;
> }
Yes, or you could simply apply the "combine linux/XFS inode" patch
series and then VFS_I(ip) will never, ever return NULL.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-16 5:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 1:49 crash with latest code drop Peter Leckie
2008-10-15 1:18 ` Dave Chinner
2008-10-15 2:29 ` Christoph Hellwig
2008-10-15 3:16 ` Dave Chinner
2008-10-15 3:24 ` Christoph Hellwig
2008-10-15 3:51 ` Dave Chinner
2008-10-15 5:50 ` Peter Leckie
2008-10-15 6:19 ` Dave Chinner
2008-10-15 7:51 ` Peter Leckie
2008-10-16 2:43 ` Peter Leckie
2008-10-16 5:55 ` Dave Chinner [this message]
2008-10-16 9:00 ` Christoph Hellwig
2008-10-17 1:01 ` Lachlan McIlroy
2008-10-22 6:19 ` Dave Chinner
2008-10-23 4:23 ` Peter Leckie
2008-10-23 5:39 ` Dave Chinner
2008-10-15 3:47 ` Peter Leckie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016055530.GE25906@disturbed \
--to=david@fromorbit.com \
--cc=pleckie@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox