From: Christoph Hellwig <hch@lst.de>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] trivial xfs_remove comment fixup
Date: Sat, 18 Oct 2008 14:36:23 +0200 [thread overview]
Message-ID: <20081018123623.GB25304@lst.de> (raw)
In-Reply-To: <20080807215849.GA11345@lst.de>
Ping? This is just a trivial comment fixup, shouldn't be that hard to
review..
On Thu, Aug 07, 2008 at 11:58:49PM +0200, Christoph Hellwig wrote:
> The dp to ip comment should be for the unconditional xfs_droplink
> call, and the "." link obviously only exists for directories,
> so it should be in the is_dir conditional.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/xfs_vnodeops.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfs_vnodeops.c 2008-08-06 17:26:37.000000000 -0300
> +++ linux-2.6-xfs/fs/xfs/xfs_vnodeops.c 2008-08-06 17:36:44.000000000 -0300
> @@ -2014,7 +2014,7 @@ xfs_remove(
> goto out_bmap_cancel;
>
> /*
> - * Drop the link from dp to ip.
> + * Drop the "." link from ip to self.
> */
> error = xfs_droplink(tp, ip);
> if (error)
> @@ -2029,7 +2029,7 @@ xfs_remove(
> }
>
> /*
> - * Drop the "." link from ip to self.
> + * Drop the link from dp to ip.
> */
> error = xfs_droplink(tp, ip);
> if (error)
---end quoted text---
next prev parent reply other threads:[~2008-10-18 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 21:58 PATCH] trivial xfs_remove comment fixup Christoph Hellwig
2008-08-08 0:33 ` Dave Chinner
2008-10-18 12:36 ` Christoph Hellwig [this message]
2008-10-21 7:36 ` [PATCH] " Donald Douwsma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081018123623.GB25304@lst.de \
--to=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox