public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Timothy Shimmin <tes@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Miklos Szeredi <miklos@szeredi.hu>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: XFS_ERROR use - was Re: [PATCH] prevent NULL returns from d_obtain_alias
Date: Mon, 20 Oct 2008 05:23:46 -0400	[thread overview]
Message-ID: <20081020092346.GA14455@infradead.org> (raw)
In-Reply-To: <48FBD5AB.6090306@sgi.com>

On Mon, Oct 20, 2008 at 11:49:47AM +1100, Timothy Shimmin wrote:
> > I have to revamp that whole
> > function anyway as it's extremly buggy in many ways, especially when
> > used to open directories (can lead to multiple dentries for a single
> > directory - ouch) and then I'll kill the other uses.
> 
> Oh ok.
> 
> In userspace,
> we use it for opening directories on xfsdump via jdm_open in order to
> do bulkstat driven dirent dumping.
> We also use it in xfsrestore - though I am not convinced we should -
> it was initially done for "performance" reasons apparently.

I think the use of the API is fine, the problem is that the current
implemention is buggy.

  reply	other threads:[~2008-10-20  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081015192839.GA867@lst.de>
     [not found] ` <E1KqWzC-00087u-TG@pomaz-ex.szeredi.hu>
     [not found]   ` <20081016180947.GA26285@lst.de>
2008-10-17  0:11     ` XFS_ERROR use - was Re: [PATCH] prevent NULL returns from d_obtain_alias Timothy Shimmin
2008-10-17  1:53       ` Dave Chinner
2008-10-17  3:04         ` Eric Sandeen
2008-10-17 17:10       ` Christoph Hellwig
2008-10-20  0:49         ` Timothy Shimmin
2008-10-20  9:23           ` Christoph Hellwig [this message]
2008-10-20 23:16             ` Timothy Shimmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081020092346.GA14455@infradead.org \
    --to=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=miklos@szeredi.hu \
    --cc=tes@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox