From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] Re: another problem with latest code drops
Date: Mon, 20 Oct 2008 17:41:33 -0400 [thread overview]
Message-ID: <20081020214133.GA20531@infradead.org> (raw)
In-Reply-To: <20081020060522.GP31761@disturbed>
On Mon, Oct 20, 2008 at 05:05:22PM +1100, Dave Chinner wrote:
> On second thoughts, the inode has not been set up properly
> by this stage, so we can't really even expect to be able to
> call iput() on it. Hmmmm - maybe the only thing we can do
> here is call security_inode_free() before xfs_idestroy.
>
> Christoph - any opinions on what the best thing to do is?
Calling destroy_inode after exporting it seems most logical. If we want
to undo init_inode_once we should have VFS functionality taking care
of that, too.
I've implemented this including some preparatory patches dealing with
the bulkstat issue. It's half-way trough xfsqa so far.
next prev parent reply other threads:[~2008-10-20 21:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 2:06 another problem with latest code drops Lachlan McIlroy
2008-10-16 6:02 ` Dave Chinner
2008-10-16 7:38 ` Lachlan McIlroy
2008-10-16 7:20 ` Dave Chinner
2008-10-16 8:35 ` Lachlan McIlroy
2008-10-16 9:08 ` Christoph Hellwig
2008-10-17 1:13 ` Lachlan McIlroy
2008-10-16 22:29 ` Dave Chinner
2008-10-17 1:17 ` Lachlan McIlroy
2008-10-17 1:21 ` Dave Chinner
2008-10-17 2:04 ` [PATCH] " Dave Chinner
2008-10-17 2:07 ` Dave Chinner
2008-10-20 2:37 ` Lachlan McIlroy
2008-10-20 3:17 ` Dave Chinner
2008-10-20 4:37 ` Lachlan McIlroy
2008-10-20 5:29 ` Dave Chinner
2008-10-20 6:05 ` Dave Chinner
2008-10-20 21:41 ` Christoph Hellwig [this message]
2008-10-17 3:14 ` Lachlan McIlroy
2008-10-19 9:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081020214133.GA20531@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox