From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat
Date: Wed, 22 Oct 2008 07:36:13 +1100 [thread overview]
Message-ID: <20081021203612.GL25906@disturbed> (raw)
In-Reply-To: <20081021081329.GA23344@infradead.org>
On Tue, Oct 21, 2008 at 04:13:29AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 21, 2008 at 01:44:55PM +1100, Dave Chinner wrote:
> > On Tue, Oct 21, 2008 at 12:20:36AM +0200, Christoph Hellwig wrote:
> > > xfs_bulkstat only wants the dinode, offset and buffer from a given
> > > inode number. Instead of using xfs_itobp on a fake inode that is much
> > > easier done with xfs_inotobp, which just needs an imap_flag paramter to
> > > pass down the XFS_IMAP_BULKSTAT flag.
> >
> > Nice - that removes the only external user of xfs_inode_alloc() very
> > cleanly. Looks ok to me.
>
> Which means we should mark it static now. Updated patch below:
Looks good.
BTW, the original patch series has run through xfsqa on my setup
overnight without any problems.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-10-21 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 22:20 [PATCH 1/3] stop using xfs_itobp in xfs_bulkstat Christoph Hellwig
2008-10-21 2:44 ` Dave Chinner
2008-10-21 8:13 ` Christoph Hellwig
2008-10-21 20:36 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021203612.GL25906@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox