From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] stop using xfs_itobp in xfs_bulkstat
Date: Thu, 23 Oct 2008 08:27:33 +1100 [thread overview]
Message-ID: <20081022212733.GR18495@disturbed> (raw)
In-Reply-To: <20081022163034.GB25556@infradead.org>
On Wed, Oct 22, 2008 at 12:30:34PM -0400, Christoph Hellwig wrote:
> xfs_bulkstat only wants the dinode, offset and buffer from a given
> inode number. Instead of using xfs_itobp on a fake inode which is
> complicated and currently leads to leaks of the security data just use
> xfs_inotobp which is designed to do exactly the kind of lookup
> xfs_bulkstat wants. The only thing that's missing in xfs_inotobp is
> a flags paramter that let's us pass down XFS_IMAP_BULKSTAT, but that can
> easily added.
Looks good.
> Index: xfs-2.6/fs/xfs/xfs_inode.h
> ===================================================================
> --- xfs-2.6.orig/fs/xfs/xfs_inode.h 2008-10-20 23:49:30.000000000 +0200
> +++ xfs-2.6/fs/xfs/xfs_inode.h 2008-10-21 09:28:03.000000000 +0200
> @@ -158,7 +158,7 @@ typedef struct xfs_icdinode {
> #define XFS_IFEXTIREC 0x08 /* Indirection array of extent blocks */
>
> /*
> - * Flags for xfs_itobp(), xfs_imap() and xfs_dilocate().
> + * Flags for xfs_inotobp, xfs_itobp(), xfs_imap() and xfs_dilocate().
> */
Not really important, but for consistency that should be
"xfs_inotobp()". Perhaps just fix that in the followup patch
that removes the imap_flags from xfs_itobp() so this can go
straight in without another round trip.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-10-22 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:30 [PATCH 1/2] stop using xfs_itobp in xfs_bulkstat Christoph Hellwig
2008-10-22 21:27 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022212733.GR18495@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox