Re: [PATCH 2/2 v2] hook up fiemap & associated formatter

Christoph Hellwig
2008-10-25T20:27:04Z

> +#define XFS_FIEMAP_FLAGS (FIEMAP_FLAG_SYNC|FIEMAP_FLAG_XATTR)

Why do we need FIEMAP_FLAG_SYNC in here? That flag is implemented in
the VFS and should be handled there. (Probably more a question for
the generic implementation than your patch)

> +
> +STATIC int xfs_fiemap_format(

STATIC int
xfs_fiemap_format(

Buit the meat of the patch looks good to me.