Re: [PATCH 2/2 v2] hook up fiemap & associated formatter

Eric Sandeen
2008-10-26T04:38:27Z

Christoph Hellwig wrote:
>> +#define XFS_FIEMAP_FLAGS (FIEMAP_FLAG_SYNC|FIEMAP_FLAG_XATTR)
>
> Why do we need FIEMAP_FLAG_SYNC in here? That flag is implemented in
> the VFS and should be handled there. (Probably more a question for
> the generic implementation than your patch)

well, sorta, it calls filemap_write_and_wait but no lock is held to keep
that consistent when the filesystem gets to it... IMHO it *should*
probably be up to the fs to handle the sync flag. But anyway, for it
all to hang together I think we need to tell it that we understand this
flag.

-Eric

>> +
>> +STATIC int xfs_fiemap_format(
>
> STATIC int
> xfs_fiemap_format(
>
>
>
> Buit the meat of the patch looks good to me.
>
>