public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: assertion failure with latest xfs
Date: Wed, 29 Oct 2008 14:29:41 +1100	[thread overview]
Message-ID: <20081029032941.GG4985@disturbed> (raw)
In-Reply-To: <4907B1B3.4020008@sgi.com>

On Wed, Oct 29, 2008 at 11:43:31AM +1100, Lachlan McIlroy wrote:
> Dave Chinner wrote:
>> Hmmmm - there's also another bug in xfs_iget_cache_hit() - we don't
>> drop the reference we got if we found an unlinked inode after the
>> igrab() (the ENOENT case). I'll fix that as well.
>>
>> Patch below that I'm currently running through xfsqa.
>
> I gave this patch a go and it still asserted at the same place running
> the same test.

Can you put more inode trace points in so that we can see where the
extra reference is coming from?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2008-10-29  3:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-23  9:08 assertion failure with latest xfs Lachlan McIlroy
2008-10-23 17:31 ` Christoph Hellwig
2008-10-23 22:21   ` Dave Chinner
2008-10-29  0:43     ` Lachlan McIlroy
2008-10-29  3:29       ` Dave Chinner [this message]
2008-10-30  2:29         ` Lachlan McIlroy
2008-10-30  5:38           ` Dave Chinner
2008-10-31  1:09             ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081029032941.GG4985@disturbed \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=lachlan@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox