Re: [patch 0/9] writeback data integrity and other fixes (take 3)

Dave Chinner
2008-10-29T21:53:58Z

On Wed, Oct 29, 2008 at 05:45:03PM -0400, Christoph Hellwig wrote:
> On Thu, Oct 30, 2008 at 08:42:02AM +1100, Dave Chinner wrote:
> > I'll do that as a separate patch - it's not really part of a "fix
> > error value inversion" bug fix....
>
> Well it is kindof. Because we'd call Linux library functions directly
> from the method we skip to places that need sign conversion and could
> possibly go wrong. But if you want a separate patch that's fine with
> me too.

Well, the patch I posted to fix the sign problems covered the
xfs_flush_pages() and xfs_flushinval_pages() functions that we
returning negative errors to core code, and none of the core code
inverted that before returning it to functions that inverted it.
That's a general problem that affected truncate, direct I/O,
getbmap, etc, as well as fsync...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com