Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing

Christoph Hellwig
2008-10-31T20:18:45Z

On Fri, Oct 31, 2008 at 12:15:25PM +1100, Dave Chinner wrote:
> XFS gets the sign of the error wrong in several places when
> gathering the error from generic linux functions. These functions
> return negative error values, while the core XFS code returns
> positive error values. Hence when XFS inverts the error to be
> returned to the VFS, it can incorrectly invert a negative
> error and this error will be ignored by the syscall return.
>
> Fix all the problems related to calling filemap_* functions.
>
> Problem initially identified by Nick Piggin in xfs_fsync().

But this patch is a little more than just the error code inversions..