Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing

Dave Chinner
2008-11-02T22:51:48Z

On Fri, Oct 31, 2008 at 04:18:30PM -0400, Christoph Hellwig wrote:
> On Fri, Oct 31, 2008 at 12:15:25PM +1100, Dave Chinner wrote:
> > XFS gets the sign of the error wrong in several places when
> > gathering the error from generic linux functions. These functions
> > return negative error values, while the core XFS code returns
> > positive error values. Hence when XFS inverts the error to be
> > returned to the VFS, it can incorrectly invert a negative
> > error and this error will be ignored by the syscall return.
> >
> > Fix all the problems related to calling filemap_* functions.
> >
> > Problem initially identified by Nick Piggin in xfs_fsync().
>
> But this patch is a little more than just the error code inversions..

Yes, that's the point of the patch - we get it wrong in many
places and this fixes them so that correctly signed error values
are returned to the higher layers....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com