Re: [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt

Christoph Hellwig
2008-10-31T20:20:40Z

On Fri, Oct 31, 2008 at 12:15:28PM +1100, Dave Chinner wrote:
> gcc is warning about an uninitialised variable in xfs_growfs_rt().
> This is a false positive. Fix it by changing the scope of the
> transaction pointer to wholly within the internal loop inside
> the function.
>
> While there, preemptively change xfs_growfs_rt_alloc() in the
> same way as it has exactly the same structure as xfs_growfs_rt()
> but gcc is not warning about it. Yet.

Looks good.