Re: do_sync() and XFSQA test 182 failures....

Christoph Hellwig
2008-10-31T20:31:36Z

On Fri, Oct 31, 2008 at 11:12:49AM +1100, Dave Chinner wrote:
> Right - that's exactly where we should be going with this, I think.
> I'd suggest two callouts, perhaps: ->sync_data and ->sync_metadata.
> The freeze code can then still operate in two stages, and we can
> also use then for separating data and inode writeback in pdflush....
>
> FWIW, I mentioned doing this sort of thing here:
>
> http://xfs.org/index.php/Improving_inode_Caching#Avoiding_the_Generic_pdflush_Code
>
> I think I'll look at redoing do_sync() to provide a custom sync
> method before trying to fix XFS....

And you weren't the first to thing of this. Reiser4 for example
has bad a patch forever to turn sync_sb_inodes into a filesystem method,
and I think something similar is what we want. When talking about
syncing we basically want a few things:

- sync out data, either async (from pdflush) or sync
(from sync, freeze, remount ro or unmount)
- sync out metadata (from pdflush), either async or sync
(from sync, freeze, remount ro or unmount)

and then we want pdflush / sync / etc call into it. If we are doing
this correctly this would also avoid having our own xfssyncd.

And as we found out it's not just sync that gets it wrong, it's also
fsync (which isn't part of the above picture as it's per-inode) that
gets this utterly wrong, as well as all kinds of syncs, not just the
unmount one. Combine this with the other data integrity issues Nick
found in write_cache_pages I come to the conclusion that this whole area
needs some profound audit and re-architecture urgently.