public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: create tape group
@ 2008-11-01 15:58 Eric Sandeen
  2008-11-02 22:05 ` Dave Chinner
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2008-11-01 15:58 UTC (permalink / raw)
  To: xfs-oss

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

Index: xfs-cmds/xfstests/group
===================================================================
--- xfs-cmds.orig/xfstests/group
+++ xfs-cmds/xfstests/group
@@ -35,6 +35,9 @@ v2log		tes@sgi.com
 # xfsdump, xfsrestore, xfsinvutil
 dump		tes@sgi.com ivanr@sgi.com
 
+# xfsdump, xfsrestore to tapes
+tape		tes@sgi.com ivanr@sgi.com
+
 # xfsdump, xfsrestore to remote tapes
 remote		tes@sgi.com ivanr@sgi.com
 
@@ -118,10 +121,10 @@ nfs4acl		tes@sgi.com donaldd@sgi.com
 019 mkfs auto
 020 metadata attr udf auto
 021 db attr auto
-022 dump ioctl auto
-023 dump ioctl auto
-024 dump ioctl auto
-025 dump ioctl auto
+022 dump ioctl tape auto
+023 dump ioctl tape auto
+024 dump ioctl tape auto
+025 dump ioctl tape auto
 026 dump ioctl auto
 027 dump ioctl auto
 028 dump ioctl auto
@@ -131,15 +134,15 @@ nfs4acl		tes@sgi.com donaldd@sgi.com
 032 mkfs auto
 033 repair auto
 034 other auto
-035 dump ioctl auto
-036 dump ioctl remote auto
-037 dump ioctl remote auto
-038 dump ioctl remote auto
-039 dump ioctl remote auto
+035 dump ioctl tape auto
+036 dump ioctl remote tape auto
+037 dump ioctl remote tape auto
+038 dump ioctl remote tape auto
+039 dump ioctl remote tape auto
 040 other auto
 041 growfs ioctl auto
 042 fsr ioctl auto
-043 dump ioctl auto
+043 dump ioctl tape auto
 044 other auto
 045 other auto
 046 dump ioctl auto
@@ -151,7 +154,7 @@ nfs4acl		tes@sgi.com donaldd@sgi.com
 052 quota db auto
 053 acl repair auto
 054 quota auto
-055 dump ioctl remote auto
+055 dump ioctl remote tape auto
 056 dump ioctl auto
 057 acl auto
 058 acl auto

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xfstests: create tape group
  2008-11-01 15:58 [PATCH] xfstests: create tape group Eric Sandeen
@ 2008-11-02 22:05 ` Dave Chinner
  2008-11-02 23:12   ` Eric Sandeen
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Chinner @ 2008-11-02 22:05 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs-oss

On Sat, Nov 01, 2008 at 10:58:36AM -0500, Eric Sandeen wrote:
> Create a tape group for anything which expects
> to dump to tape (I guess this is a superset
> of "remote" and a few others).

Given that most ppl don't have tape drives, should these be left in
the auto group now that they can easily be run by 'check -g tape'? I
know I've never had a config to run them the *entire* time I've 
personally run XFSQA...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xfstests: create tape group
  2008-11-02 22:05 ` Dave Chinner
@ 2008-11-02 23:12   ` Eric Sandeen
  2008-11-03  0:27     ` Dave Chinner
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2008-11-02 23:12 UTC (permalink / raw)
  To: Eric Sandeen, xfs-oss

Dave Chinner wrote:

> On Sat, Nov 01, 2008 at 10:58:36AM -0500, Eric Sandeen wrote:
>   
>> Create a tape group for anything which expects
>> to dump to tape (I guess this is a superset
>> of "remote" and a few others).
>>     
>
> Given that most ppl don't have tape drives, should these be left in
> the auto group now that they can easily be run by 'check -g tape'? I
> know I've never had a config to run them the *entire* time I've 
> personally run XFSQA...
>
> Cheers,
>
> Dave.
>   
Sounds like a plan.  We probably don't even know (?) if they run
well enough to be in the auto group?  Revised patch below:

-----------------

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).  Also, remove
this from the auto group; most people won't have tapes
and -g tape is easy enough (per dchinner's suggestion).

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

Index: xfs-cmds/xfstests/group
===================================================================
--- xfs-cmds.orig/xfstests/group
+++ xfs-cmds/xfstests/group
@@ -35,6 +35,9 @@ v2log		tes@sgi.com
 # xfsdump, xfsrestore, xfsinvutil
 dump		tes@sgi.com ivanr@sgi.com
 
+# xfsdump, xfsrestore to tapes
+tape		tes@sgi.com ivanr@sgi.com
+
 # xfsdump, xfsrestore to remote tapes
 remote		tes@sgi.com ivanr@sgi.com
 
@@ -118,10 +121,10 @@ nfs4acl		tes@sgi.com donaldd@sgi.com
 019 mkfs auto
 020 metadata attr udf auto
 021 db attr auto
-022 dump ioctl auto
-023 dump ioctl auto
-024 dump ioctl auto
-025 dump ioctl auto
+022 dump ioctl tape
+023 dump ioctl tape
+024 dump ioctl tape
+025 dump ioctl tape
 026 dump ioctl auto
 027 dump ioctl auto
 028 dump ioctl auto
@@ -131,15 +134,15 @@ nfs4acl		tes@sgi.com donaldd@sgi.com
 032 mkfs auto
 033 repair auto
 034 other auto
-035 dump ioctl auto
-036 dump ioctl remote auto
-037 dump ioctl remote auto
-038 dump ioctl remote auto
-039 dump ioctl remote auto
+035 dump ioctl tape auto
+036 dump ioctl remote tape
+037 dump ioctl remote tape
+038 dump ioctl remote tape
+039 dump ioctl remote tape
 040 other auto
 041 growfs ioctl auto
 042 fsr ioctl auto
-043 dump ioctl auto
+043 dump ioctl tape
 044 other auto
 045 other auto
 046 dump ioctl auto
@@ -151,7 +154,7 @@ nfs4acl		tes@sgi.com donaldd@sgi.com
 052 quota db auto
 053 acl repair auto
 054 quota auto
-055 dump ioctl remote auto
+055 dump ioctl remote tape
 056 dump ioctl auto
 057 acl auto
 058 acl auto

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] xfstests: create tape group
  2008-11-02 23:12   ` Eric Sandeen
@ 2008-11-03  0:27     ` Dave Chinner
  0 siblings, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2008-11-03  0:27 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs-oss

On Sun, Nov 02, 2008 at 05:12:17PM -0600, Eric Sandeen wrote:
> Dave Chinner wrote:
> 
> > On Sat, Nov 01, 2008 at 10:58:36AM -0500, Eric Sandeen wrote:
> >   
> >> Create a tape group for anything which expects
> >> to dump to tape (I guess this is a superset
> >> of "remote" and a few others).
> >>     
> >
> > Given that most ppl don't have tape drives, should these be left in
> > the auto group now that they can easily be run by 'check -g tape'? I
> > know I've never had a config to run them the *entire* time I've 
> > personally run XFSQA...
> >
> > Cheers,
> >
> > Dave.
> >   
> Sounds like a plan.  We probably don't even know (?) if they run
> well enough to be in the auto group?  Revised patch below:

Looks OK to me.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-11-03  0:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-01 15:58 [PATCH] xfstests: create tape group Eric Sandeen
2008-11-02 22:05 ` Dave Chinner
2008-11-02 23:12   ` Eric Sandeen
2008-11-03  0:27     ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox