From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing
Date: Mon, 3 Nov 2008 09:51:33 +1100 [thread overview]
Message-ID: <20081102225133.GI19509@disturbed> (raw)
In-Reply-To: <20081031201830.GA20309@infradead.org>
On Fri, Oct 31, 2008 at 04:18:30PM -0400, Christoph Hellwig wrote:
> On Fri, Oct 31, 2008 at 12:15:25PM +1100, Dave Chinner wrote:
> > XFS gets the sign of the error wrong in several places when
> > gathering the error from generic linux functions. These functions
> > return negative error values, while the core XFS code returns
> > positive error values. Hence when XFS inverts the error to be
> > returned to the VFS, it can incorrectly invert a negative
> > error and this error will be ignored by the syscall return.
> >
> > Fix all the problems related to calling filemap_* functions.
> >
> > Problem initially identified by Nick Piggin in xfs_fsync().
>
> But this patch is a little more than just the error code inversions..
Yes, that's the point of the patch - we get it wrong in many
places and this fixes them so that correctly signed error values
are returned to the higher layers....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-11-02 22:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 1:15 [PATCH 0/5] Miscellaneous bug fixes Dave Chinner
2008-10-31 1:15 ` [PATCH 1/5] XFS: fix error inversion problems with data flushing Dave Chinner
2008-10-31 20:18 ` Christoph Hellwig
2008-11-02 22:51 ` Dave Chinner [this message]
2008-11-06 15:39 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 2/5] XFS: Fix double free of log tickets Dave Chinner
2008-11-12 9:20 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 3/5] XFS: fix uninitialised variable bug in dquot release Dave Chinner
2008-10-31 20:19 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt Dave Chinner
2008-10-31 20:20 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 5/5] XFS: Avoid using inodes that haven't been completely initialised Dave Chinner
2008-10-31 20:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081102225133.GI19509@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox