From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/3 v4] Add new flags to getbmapx interface
Date: Wed, 12 Nov 2008 04:22:36 -0500 [thread overview]
Message-ID: <20081112092236.GC8896@infradead.org> (raw)
In-Reply-To: <49089644.8070402@sandeen.net>
On Wed, Oct 29, 2008 at 11:58:44AM -0500, Eric Sandeen wrote:
> Add new getbmap flags.
>
> This adds a new output flag, BMV_OF_LAST to indicate if we've hit
> the last extent in the inode. This potentially saves an extra call
> from userspace to see when the whole mapping is done.
>
> It also adds BMV_IF_DELALLOC and BMV_OF_DELALLOC to request, and
> indicate, delayed-allocation extents. In this case bmv_block
> is set to -2 (-1 was already taken for HOLESTARTBLOCK; unfortunately
> these are the reverse of the in-kernel constants.)
>
> These new flags facilitate addition of the new fiemap interface.
>
> Rather than adding sh_delalloc, remove sh_unwritten & just test
> the flags directly.
Looks good.
next prev parent reply other threads:[~2008-11-12 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 16:55 [PATCH 0/3 v4] hook xfs to fiemap ioctl Eric Sandeen
2008-10-29 16:58 ` [PATCH 1/3 v4] convert xfs_getbmap to take formatter functions Eric Sandeen
2008-11-12 9:21 ` Christoph Hellwig
2008-10-29 16:58 ` [PATCH 2/3 v4] Add new flags to getbmapx interface Eric Sandeen
2008-11-12 9:22 ` Christoph Hellwig [this message]
2008-10-29 16:59 ` [PATCH 3/3 v4] hook up fiemap & associated formatter Eric Sandeen
2008-11-12 9:22 ` Christoph Hellwig
2008-11-19 4:59 ` Eric Sandeen
2008-11-12 9:23 ` [PATCH 0/3 v4] hook xfs to fiemap ioctl Christoph Hellwig
2008-11-12 13:33 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112092236.GC8896@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox