* [PATCH] xfstest: confirm mkfs.gfs[2] in test 032
@ 2008-11-01 16:13 Eric Sandeen
2008-11-01 19:19 ` [PATCH v2] " Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2008-11-01 16:13 UTC (permalink / raw)
To: xfs-oss
mkfs.gfs[2] asks for confirmation before mkfs'ing; without
this test 032 hangs when mkfs.gfs2 is present.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
Index: xfs-cmds/xfstests/032
===================================================================
--- xfs-cmds.orig/xfstests/032
+++ xfs-cmds/xfstests/032
@@ -43,6 +43,8 @@ do
[ $fs = vfat ] && postargs=2000
# these folks prompt before writing
[ $fs = jfs ] && preop="echo Y |"
+ [ $fs = gfs ] && preop="echo y |"
+ [ $fs = gfs2 ] && preop="echo y |"
[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
# cramfs mkfs requires a directory argument
[ $fs = cramfs ] && preargs=/proc/fs/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] xfstest: confirm mkfs.gfs[2] in test 032
2008-11-01 16:13 [PATCH] xfstest: confirm mkfs.gfs[2] in test 032 Eric Sandeen
@ 2008-11-01 19:19 ` Eric Sandeen
2008-11-12 9:42 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2008-11-01 19:19 UTC (permalink / raw)
To: xfs-oss
mkfs.gfs[2] asks for confirmation before mkfs'ing; without
this test 032 hangs when mkfs.gfs2 is present.
Also, mkfs.gfs needs a few more args to make it go.
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
Index: xfs-cmds/xfstests/032
===================================================================
--- xfs-cmds.orig/xfstests/032
+++ xfs-cmds/xfstests/032
@@ -43,6 +43,8 @@ do
[ $fs = vfat ] && postargs=2000
# these folks prompt before writing
[ $fs = jfs ] && preop="echo Y |"
+ [ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
+ [ $fs = gfs2 ] && preop="echo y |"
[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
# cramfs mkfs requires a directory argument
[ $fs = cramfs ] && preargs=/proc/fs/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] xfstest: confirm mkfs.gfs[2] in test 032
2008-11-01 19:19 ` [PATCH v2] " Eric Sandeen
@ 2008-11-12 9:42 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2008-11-12 9:42 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Sat, Nov 01, 2008 at 02:19:10PM -0500, Eric Sandeen wrote:
> mkfs.gfs[2] asks for confirmation before mkfs'ing; without
> this test 032 hangs when mkfs.gfs2 is present.
>
> Also, mkfs.gfs needs a few more args to make it go.
Looks good.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-12 9:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-01 16:13 [PATCH] xfstest: confirm mkfs.gfs[2] in test 032 Eric Sandeen
2008-11-01 19:19 ` [PATCH v2] " Eric Sandeen
2008-11-12 9:42 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox